Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Viewing Coin Trending in Twitter (Trade Plugin) #1458

Merged
merged 16 commits into from
Sep 4, 2020
Merged

Support Viewing Coin Trending in Twitter (Trade Plugin) #1458

merged 16 commits into from
Sep 4, 2020

Conversation

guanbinrui
Copy link
Member

@guanbinrui guanbinrui commented Aug 21, 2020 •
edited
Loading

  • Add <WholePostView />
  • Add TypedMessageAnchor
  • Add <TrendingView />
  • Integrate <TrendingView /> with CMC & CoinGecko API
  • Replace original post with <WholePostView />

The Trending View

preview-1
preview-2

The settings about WholePostView (#1450)

settings panel

@guanbinrui guanbinrui changed the title Feature/treading Support Viewing Coin Treading in Twitter Aug 21, 2020
@guanbinrui guanbinrui changed the title Support Viewing Coin Treading in Twitter Support Viewing Coin Trending in Twitter Aug 21, 2020
@guanbinrui guanbinrui force-pushed the feature/treading branch 4 times, most recently from e5c7dc6 to f69e9e7 Compare August 26, 2020 04:01
@guanbinrui guanbinrui changed the title Support Viewing Coin Trending in Twitter Support Viewing Coin Trending in Twitter (Trade Plugin) Aug 28, 2020
@guanbinrui guanbinrui force-pushed the feature/treading branch 10 times, most recently from b798fdc to 41457c3 Compare September 1, 2020 03:58
septs
septs suggested changes Sep 1, 2020
View reviewed changes
src/components/InjectedComponents/PageInspector.tsx Show resolved Hide resolved
src/plugins/Trader/apis/coinmarketcap/index.ts Outdated Show resolved Hide resolved
src/plugins/Wallet/formatter.ts Outdated Show resolved Hide resolved
src/plugins/Trader/define.tsx Outdated Show resolved Hide resolved
src/plugins/Trader/define.tsx Outdated Show resolved Hide resolved
@guanbinrui guanbinrui marked this pull request as ready for review September 1, 2020 10:12
@guanbinrui guanbinrui requested a review from septs September 1, 2020 11:13
septs
septs suggested changes Sep 2, 2020
View reviewed changes
src/plugins/Trader/apis/coingecko/index.ts Outdated Show resolved Hide resolved
src/plugins/Trader/apis/coinmarketcap/index.ts Outdated Show resolved Hide resolved
src/plugins/Trader/apis/coinmarketcap/index.ts Show resolved Hide resolved
@neruthes
Copy link
Contributor

neruthes commented Sep 4, 2020

I propose using the following text for the settings option:

Lang Title Description Options
en Substitute Post All posts on the webpages will be rendered by Maskbook, including those not created by Maskbook. ON; OFF
zh 替身 Post 網頁上每個 Post 都由 Maskbook 渲染，包括並非由 Maskbook 創建的。

septs
septs suggested changes Sep 4, 2020
View reviewed changes
src/plugins/Trader/types.ts Show resolved Hide resolved
septs
septs previously approved these changes Sep 4, 2020
View reviewed changes
@guanbinrui
Copy link
Member Author

guanbinrui commented Sep 4, 2020 •
edited
Loading

網頁上每個 Post 都由 Maskbook 渲染，包括並非由 Maskbook 創建的。

Revamp it in the next PR about the trade dialog.

@neruthes
Copy link
Contributor

neruthes commented Sep 4, 2020

Is this going to close #1399? Or is this PR only a stage-1 work?

@neruthes
Copy link
Contributor

neruthes commented Sep 4, 2020

網頁上每個 Post 都由 Maskbook 渲染，包括並非由 Maskbook 創建的。

Revamp it in the next PR about trade dialog.

Ok.

@guanbinrui
Copy link
Member Author

Is this going to close #1399? Or is this PR only a stage-1 work?

Only stage-1 work.

@guanbinrui guanbinrui merged commit d2179ec into master Sep 4, 2020
@guanbinrui guanbinrui deleted the feature/treading branch September 4, 2020 03:07
guanbinrui referenced this pull request Sep 4, 2020
@guanbinrui
chore: revamp PostReplacement settings
532caeb 
more: https://github.com/DimensionDev/Maskbook/pull/1458\#issuecomment-686867383
guanbinrui referenced this pull request Sep 4, 2020
@guanbinrui
chore: revamp PostReplacement settings
f825ee5 
more: https://github.com/DimensionDev/Maskbook/pull/1458\#issuecomment-686867383
guanbinrui referenced this pull request Sep 4, 2020
@guanbinrui
chore: revamp PostReplacement settings
2d9a4ce 
more: https://github.com/DimensionDev/Maskbook/pull/1458\#issuecomment-686867383
guanbinrui referenced this pull request Sep 4, 2020
@guanbinrui
chore: revamp PostReplacement settings
d6a7472 
more: https://github.com/DimensionDev/Maskbook/pull/1458\#issuecomment-686867383
@guanbinrui guanbinrui mentioned this pull request Sep 4, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neruthes neruthes neruthes left review comments

@Jack-Works Jack-Works Jack-Works approved these changes

@septs septs Awaiting requested review from septs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guanbinrui @septs @neruthes @Jack-Works